feat(creation): Implement joint account creation flow by yasin-ce · Pull Request #517 · perawallet/pera-android

yasin-ce · 2026-01-20T09:23:49Z

Summary

Add AddAccountIntroFragment with create joint account option
Add NameJointAccountFragment for account naming
Add AddJointAccountFragment for participant selection
Add SetThresholdFragment for threshold configuration
Add CreateJointAccountFragment for final creation
Add CreateJointAccountUseCase with validation
Add JointAccountInfoDialog for feature explanation
Add JointAccountSignRequestFragment for sign request handling
Add PendingSignaturesBottomSheet for signature status
Add JointAccountLedgerSignHelper for Ledger device signing

Test Plan

Create joint account with 2 participants, threshold 2
Create joint account with 3 participants, threshold 2
Verify participant validation (no duplicates, valid addresses)
Verify threshold validation (≤ participant count)
Test Ledger participant signing flow
Test contact creation for external addresses

- Fix duplicate DI bindings for joint account repository - Add missing interface implementations - Update transaction signer handling for joint accounts - Fix import statements and code organization

- Add CreateJointAccountFragment and ViewModel - Add NameJointAccountFragment for account naming - Add AddJointAccountFragment for participant selection - Implement JointAccountTransactionSignHelper - Add CreateJointAccountUseCase - Add participant selection UI components - Handle contact creation for external addresses

- Update AccountAssetsFragment to use onInboxClick - Update AccountAssetsAccountDetailAdapter to call listener.onInboxClick - Update AccountDetailQuickActionsView to match Inbox sealed class

…ation-flow

…ation-flow * multisig/06-account-pages-support: fix(di): Add missing GetJointAccount and GetJointAccountParticipantCount bindings fix(test): Use correct domain model class names in HasInboxItemsForAddressUseCaseTest

Architecture: - app module (UI only): Fragments, Screens, ViewModels that use interfaces - common-sdk domain layer (public): UseCase interfaces, Domain models - common-sdk data layer (internal): Repository (internal), UseCase implementations, Services, Mappers Changes: - Make JointAccountRepository internal - Create use case interfaces for each repository function: - CreateJointAccount - GetInboxMessages - DeleteInboxJointInvitationNotification - Create internal use case implementations - Delete duplicate data layer from app module - Update app module to use common-sdk use cases - Add Dagger bindings for new use cases

Fix Fragment lifecycle violations where initSavedStateListener was called in onResume instead of onViewCreated: - ContactInfoFragment: Remove duplicate call in onResume (was in both) - AccountHistoryFragment: Move to onViewCreated - Arc59SendSummaryFragment: Move to onViewCreated, remove empty onResume - InAppPinFragment: Move to onViewCreated, remove empty onResume This ensures SavedState listeners are registered early in the lifecycle and prevents missing initial state emissions.

…tion The existing GetInboxMessages in InboxUseCases.kt gets cached data. The new FetchInboxMessages fetches from the API via repository.

- Replace *DTO suffix with actual domain model names - ParticipantSignatureDTO -> ParticipantSignature - JointSignRequestDTO -> JointSignRequest - SignRequestWithFullSignatureDTO -> SignRequestWithFullSignature - TransactionListWithFullSignatureDTO -> TransactionListWithFullSignature - SignRequestTransactionListResponseDTO -> AddSignatureInput - Fix PeraResult.Success/Error usage in DefaultJointAccountDetailProcessor

…ation-flow

mitsinsar · 2026-01-26T12:10:58Z

...algorand/android/modules/addaccount/intro/domain/usecase/GetAddAccountIntroPreviewUseCase.kt

+    private val isThereAnyLocalAccount: IsThereAnyLocalAccount
+) : GetAddAccountIntroPreview {
+
+    override fun invoke(isShowingCloseButton: Boolean): Flow<AddAccountIntroPreview> = flow {


unnecessary flow. We can return the result as AddAccountIntroPreview

mitsinsar · 2026-01-26T12:12:39Z

...kotlin/com/algorand/android/modules/addaccount/intro/mapper/AddAccountIntroPreviewDecider.kt

+import com.algorand.android.R
+import javax.inject.Inject
+
+class AddAccountIntroPreviewDecider @Inject constructor() {


We can move these functions in mapper

mitsinsar · 2026-01-26T12:14:08Z

...n/kotlin/com/algorand/android/modules/addaccount/intro/viewmodel/AddAccountIntroViewModel.kt

+    sealed interface ViewState {
+        data object Idle : ViewState
+        data class Content(
+            val preview: AddAccountIntroPreview


We can remove preview class move fields here

mitsinsar · 2026-01-26T12:16:52Z

...ndroid/modules/addaccount/joint/creation/ui/addaccount/viewmodel/AddJointAccountViewModel.kt

+    fun onSearchQueryUpdate(query: String) {
+        stateDelegate.updateState { it.copy(searchQuery = query) }
+        searchJob?.cancel()
+        searchJob = viewModelScope.launch {


We should use flow.debounce instead of creating scope and waiting

mitsinsar · 2026-01-26T12:21:26Z

...lgorand/android/modules/addaccount/joint/creation/usecase/AddJointAccountSelectionUseCase.kt

+
+    fun getAccountSelectionList(
+        query: String,
+    ): Flow<List<JointAccountSelectionListItem>> {


these functions are not observing flows, they are just getting results as flow. There is no point of returning flow here as well as using combine function. you can simply return the result. This is creating unnecessary flows each time query is updated

mitsinsar · 2026-01-27T08:58:45Z

...nd/android/modules/addaccount/joint/creation/ui/namejointaccount/NameJointAccountFragment.kt

+        mainActivity?.showAlertSuccess(
+            title = getString(R.string.account_has_been_added),
+            description = null,
+            tag = this::class.simpleName.orEmpty()


function's default tag parameter is already set, no need to set the same parameter

mitsinsar · 2026-01-27T12:51:18Z

...d/android/modules/addaccount/joint/transaction/domain/usecase/CreateSignerAccountsUseCase.kt

+        }
+    }
+
+    override suspend fun hasSigningCapableLocalAccount(address: String): Boolean {


Critical issue

mitsinsar · 2026-01-27T12:53:31Z

...d/android/modules/addaccount/joint/transaction/domain/usecase/CreateSignerAccountsUseCase.kt

+        }
+        val contact = contactRepository.getContactByAddress(address)
+        val localAccount = getLocalAccount(address)
+        val isLedger = localAccount is LocalAccount.LedgerBle


Critical issue

mitsinsar · 2026-01-27T13:03:18Z

...ules/addaccount/joint/transaction/domain/usecase/GetJointAccountTransactionPreviewUseCase.kt

+            participantData.localParticipants.isEmpty() ||
+            !hasUnsigned
+
+        return JointAccountTransactionPreview(


ViewState instead of preview

mitsinsar · 2026-01-27T14:18:50Z

.../modules/addaccount/joint/creation/ui/createaccount/viewmodel/CreateJointAccountViewModel.kt

+    }
+
+    companion object {
+        private const val MIN_PARTICIPANTS_COUNT = 2


We can use existing JointAccount constant for this

yasin-ce requested review from mitsinsar and wjbeau as code owners January 20, 2026 09:23

yasin-ce self-assigned this Jan 20, 2026

yasin-ce force-pushed the multisig/06-account-pages-support branch from 4b6f926 to f44cf3b Compare January 20, 2026 09:32

yasin-ce force-pushed the multisig/07-creation-flow branch from 5b34bb9 to 9fa3c15 Compare January 20, 2026 09:32

yasin-ce force-pushed the multisig/06-account-pages-support branch from f44cf3b to c787611 Compare January 20, 2026 09:49

yasin-ce force-pushed the multisig/07-creation-flow branch from 9fa3c15 to 91daf6f Compare January 20, 2026 09:49

yasin-ce added 3 commits January 20, 2026 15:36

chore(multisig): Miscellaneous updates and fixes

de0544d

- Fix duplicate DI bindings for joint account repository - Add missing interface implementations - Update transaction signer handling for joint accounts - Fix import statements and code organization

fix: Rename onAssetInboxClick to onInboxClick for consistency

ab2aecc

- Update AccountAssetsFragment to use onInboxClick - Update AccountAssetsAccountDetailAdapter to call listener.onInboxClick - Update AccountDetailQuickActionsView to match Inbox sealed class

yasin-ce force-pushed the multisig/06-account-pages-support branch from c787611 to 8bd9179 Compare January 20, 2026 13:49

yasin-ce force-pushed the multisig/07-creation-flow branch from 91daf6f to ab2aecc Compare January 20, 2026 13:49

yasin-ce added 11 commits January 22, 2026 14:19

Merge branch 'multisig/06-account-pages-support' into multisig/07-cre…

ce8ec6a

…ation-flow

fix: Rename GetInboxMessages to FetchInboxMessages to avoid redeclara…

a3866d5

…tion The existing GetInboxMessages in InboxUseCases.kt gets cached data. The new FetchInboxMessages fetches from the API via repository.

Merge branch 'multisig/06-account-pages-support' into multisig/07-cre…

fe51734

…ation-flow

Fix compilation errors and update tests for normalized schema

7269f6d

Merge branch 'multisig/06-account-pages-support' into multisig/07-cre…

971cde9

…ation-flow

Merge branch 'multisig/06-account-pages-support' into multisig/07-cre…

ec4acfc

…ation-flow

fix: Remove @nAmed annotation referencing removed INJECTION_NAME

450fedb

mitsinsar reviewed Jan 27, 2026

View reviewed changes

mitsinsar mentioned this pull request Jan 30, 2026

Multisig Feature #522

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(creation): Implement joint account creation flow#517

feat(creation): Implement joint account creation flow#517
yasin-ce wants to merge 14 commits intomultisig/06-account-pages-supportfrom
multisig/07-creation-flow

yasin-ce commented Jan 20, 2026

Uh oh!

mitsinsar Jan 26, 2026

Uh oh!

mitsinsar Jan 26, 2026

Uh oh!

mitsinsar Jan 26, 2026

Uh oh!

mitsinsar Jan 26, 2026

Uh oh!

mitsinsar Jan 26, 2026

Uh oh!

mitsinsar Jan 27, 2026

Uh oh!

mitsinsar Jan 27, 2026

Uh oh!

mitsinsar Jan 27, 2026

Uh oh!

mitsinsar Jan 27, 2026

Uh oh!

mitsinsar Jan 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

yasin-ce commented Jan 20, 2026

Summary

Test Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants